WIP: Karlson design set imports more variables than it should

Hello!

When importing the Karlson design set, hundreds more variables than expected are imported.

It seems to also import global variables from other design sets (like Liv, Sizzle and Reality), resulting in hundreds of unused variables, with conflicting or duplicated names.

I’ve been able to reproduce the issue on two different websites, since Wireframes moved out of the experimental phase.

Thanks a lot,

Hi,
Thanks so much for your report!

I can replicate the problem and have added it to the internal bug tracker. We will update this thread as soon as it is fixed. For some reason, the color variables from the other design sets also want to be imported…

Best regards,
timmse

Hello @timmse ,

Glad to know you were able to reproduce the issue! :smiley:

Not only it imports color variables from other design sets, but it also imports multiple --brxw-text-fluid-? and --brxw-space-fluid-? variables (e.g: --brxw-text-fluid-4xl is duplicated 4 times).

Thanks,

No, the --brxw-text-fluid variables do serve a purpose.

The templates were created before Bricks itself was capable of generating fluid typography or spacing scales. As a result, we created fluid typo- and spacing scales externally and defined specific variables for them. Then we use them within the --brxw-text-xx and --brxw-space-xx variables as the value.

However, in the future, we will transition the text, spacing, and color variables to the native typography/spacing scales and color palettes, and the fluid variables will be deprecated.

The fact that some of them occur multiple times is due to the bug.