SOLVED: Structure panel dropdown Convert button doesn't work like Wrap and Insert

Bugs
1

Bricks Version: 1.5b

Hi,

In structure panel righ-click dropdown menu, Wrap and Insert button are awesome, but the Convert button doesn’t work like them.

It should have the same behaviour: default target and whole button clickable, not only the right icon.

image

2

Hi Yan,
Thanks so much for your report!

From my point of view, this is not a bug, because there is no default when converting (as opposed to wrapping or inserting) an element. When converting a section, for example, you have the choice between div and container, but we have not defined a standard for this, because it will probably be different from user to user (personal preference).

Another example: You can choose between section and container if you convert a DIV on the root level. Again, it is up to the user to decide whether to use a section or a container.

If the convert button shows only one option, you could make the whole button clickable, but the behavior would be different with two options. That would be significantly more confusing from my point of view.

Best regards,
timmse

3

Mmmhh OK…

Maybe because I actually spent hours converting containers to divs after upgrading, I feel it could be default :rofl:

Anyway I found a real bug:

image

Hovering the Convert container option changes the Wrap label :wink:

4

That’s right and I noticed it earlier too :handshake:

5

There’s actually a real bug with this for me, because when clicking the convert label, dropdown closes with no action taken.
If label is not clickable, dropdown should not close, it would be less confusing than letting us believe the click was actually taken into account. And then we click the icon.

So either the click triggers action and closes menu, either it doesn’t do anything.

6

No offense, but in your other thread, you complain that the menu stays open all the time and now it should possibly stay open, although nothing happens (which can be seen from the fact that nothing changes in the structure panel)?

However, I mentioned it along with the other problem, maybe Thomas has an idea about it.

Best regards,
timmse

7

Maybe I was not clear enough… :rofl:

As the Convert label is not clickable, no action is taken, so menu shouldn’t close, it’s like clicking on a neutral area, like nothing happened. User will then move the mouse toward the icon and click and voila.

If the menu closes after a click, user will think something was done, but in this case nothing is done, it’s very confusing.

There’s another matter to be considered… Accessibility.

8

Hey Yan,
Do you still encounter issues with the context menu?

As far as I can see, in Bricks 1.5, it works as it should :slight_smile:

Best regards,
timmse