SOLVED: Some bugs in the popup builder

Bugs
1

Browser: Chrome 114 / Samsung browser
OS: Windows
URL: page – Try Bricks – t7b3ff1b

While working with the popup builder, I noticed some bugs that I want to point out.

1- When we create the popup and the editor loads, the popup won’t show until we add a section.(Maybe this is normal behavior. But as far as I remember, this wasn’t the case when the pop-up was originally released)

a
a1331×591 38.1 KB

2- Samsung mobile phones and even browsers have options at the bottom of the page. When we place the popup at the bottom, the popup ignores these sections.

What is executed in the editor :

b
b956×551 20.4 KB

What we see in mobile (front end) :

c
c304×654 26.9 KB

As you can see in the above image, there is a lot of pop scratch under the bottom menu section of the browser.

3- When we use the undo redu buttons in the popup builder, these two buttons do not control the style changes in the popup settings.

For example, in the popup settings, change the color of the popup content. Go back to the editor and click on the Undo button. The color of the popup content will not return to its original state.

4- In the popup settings, increase the height of the content. After that, the pop-up content will be placed at the top of the pop-up by default. There is no option to align the content after increasing the height of the popup. Am I wrong?

d
d925×423 20.8 KB

2

Hi Hosein,
Thanks again so much for your report!

  1. Confirmed. The “Click on any element to add it to your popup.” area is still there but covered by the backdrop for some strange reasons (see below the red rectangle).

  2. This is a fundamental problem on mobile devices and 100vh, not just Samsung devices. You can counteract this by adding the following code to Bricks Settings Custom Code Header Scripts, which should solve the problem for now. I will discuss the issue with the developers. Source: Don't use 100vh for mobile responsive - DEV Community

<script>

const documentHeight = () => {
 const doc = document.documentElement
 doc.style.setProperty('--doc-height', `${window.innerHeight}px`)
}
window.addEventListener(‘resize’, documentHeight)
documentHeight()

</script>


<style>
:root {
 --doc-height: 100%;
}

.brx-popup {
 height: 100vh; /* fallback for Js load */
 height: var(--doc-height);
}
</style>
  1. Confirmed.
  2. That’s right, but why do you want to set a fixed height? Theoretically you can also use padding-top/bottom, and the content will align itself accordingly :thinking:

Alternative:

.brx-popup-content {
  justify-content: center;
}

Best regards,
timmse

1 Like
3

Hi Hosein,
We’ve fixed issue #1 & #2 in Bricks 1.8.2, now available as a one-click update in your WordPress Dashboard.

#3 is not a bug. We don’t enable undo/redo of those datasets (also not with the Theme Styles) for performance reasons.

Please let us know if you are still experiencing issues.

Best regards,
timmse

1 Like