SOLVED: Don't add video element if dynamic data is empty

Bricks Version: 1.5rc2
Browser: doensn’t matter
OS: macOS
URL: –

Hi,
I am having a section which can have a background video which is pulled from an acf field. If it is empty, the featured should show. It kind of works but the video element and the has-video class are still applied even though the data-background-video-url attribute is empty. It would be helpful to only echo the video element + class only if there is some actual data. Just an additional check. It is a minor thing but could reduce some bloat.

regards,
Jonathan

Hello @Jonathan

Thank you for your post.

Indeed we could add an additional check to verify if the Dynamic Data tag is empty before adding the video wrapper. I’m adding this to our development backlog and we’ll discuss this with the team.

Thank you!
Luis

1 Like

Hi @luistinygod Have the Bricks team expanded? :smiley:

1 Like

This would make lot of sense … fully support this request

1 Like

Hi @Jonathan,
We’ve fixed this bug in Bricks 1.5.1 RC, which is now available as a manual download in your account.

Please let us know if you are still experiencing issues.

Best regards,
timmse

1 Like